From: Bill Erickson <berickxx@gmail.com>
Date: Tue, 24 Jul 2018 21:26:08 +0000 (-0400)
Subject: JBAS-1925 eCard code generator skips vowels
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=2103335b24be4bcf3e94047981dbad54d00743b7;p=working%2FEvergreen.git

JBAS-1925 eCard code generator skips vowels

To avoid creating any words which could be offensive.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Ecard.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Ecard.pm
index f6db282a3f..ba8ae43903 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Ecard.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Ecard.pm
@@ -55,7 +55,8 @@ my @api_fields = (
 
 # Random 6-character alpha-numeric code that avoids look-alike characters
 # https://ux.stackexchange.com/questions/53341/are-there-any-letters-numbers-that-should-be-avoided-in-an-id
-my @code_chars = ('A','C'..'F','H','J'..'N','P','R','T'..'Y','3','4','7','9');
+# Also exclude vowels to avoid creating any real (potentially offensive) words.
+my @code_chars = ('C','D','F','H','J'..'N','P','R','T','V','W','X','3','4','7','9');
 sub generate_verify_code {
     my $string = '';
     $string .= $code_chars[rand @code_chars] for 1..6;