From: Bill Erickson <berickxx@gmail.com>
Date: Thu, 1 Dec 2022 20:08:08 +0000 (-0500)
Subject: LP1901930 Add some missing SIP fields; repairs
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=217a524a21c045b551878420124f0e8a2736f88b;p=working%2FEvergreen.git

LP1901930 Add some missing SIP fields; repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
index 52ca3b03d8..6582f1b05f 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
@@ -362,7 +362,6 @@ sub handle_patron_info {
 
 sub handle_patron_status {
     my ($session, $message) = @_;
-    my $sip_account = $session->sip_account;
 
     my $barcode = $SC->get_field_value($message, 'AA');
     my $password = $SC->get_field_value($message, 'AD');
@@ -812,7 +811,8 @@ sub handle_end_patron_session {
     return {
         code => '36',
         fixed_fields => [
-            $SC->sipbool(1)
+            $SC->sipbool(1),
+            $SC->sipdate
         ],
         fields => [
             {AO => $config->{institution}},
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Common.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Common.pm
index b51bc4e99e..c453763caf 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Common.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Common.pm
@@ -66,9 +66,8 @@ sub count4 {
 sub get_field_value {
     my ($class, $message, $code) = @_;
     for my $field (@{$message->{fields}}) {
-        while (my ($c, $v) = each(%$field)) { # one pair per field
-            return $v if $c eq $code;
-        }
+        my ($c) = keys(%$field);
+        return $field->{$c} if $c eq $code;
     }
 
     return undef;