From: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Date: Wed, 21 Mar 2012 14:03:18 +0000 (-0400)
Subject: TPAC: suppress warning about splice() when the array in question is too short
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=21b72b3848b27a2d71c88b8833a365cec4fb7325;p=evergreen%2Fpines.git

TPAC: suppress warning about splice() when the array in question is too short

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
index ecf8ef0b04..5c13a83414 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
@@ -657,7 +657,7 @@ sub staff_save_search {
 
     unshift @$list, $query unless $already{$query};
 
-    splice @$list, $sss_size;
+    splice @$list, $sss_size if scalar @$list > $sss_size;
 
     $cache_key = $U->simplereq(
         "open-ils.actor",