From: erickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Thu, 2 Sep 2010 21:06:14 +0000 (+0000)
Subject: back-porting: 17390 => disallow self-check login w/ inactive barcode
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=229b663e52f7b6d8c2d757ad91818ac53f6cbf65;p=working%2FEvergreen.git

back-porting: 17390 => disallow self-check login w/ inactive barcode

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@17457 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js b/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js
index ec4ee8c68d..6bc4c9e90f 100644
--- a/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js
+++ b/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js
@@ -341,7 +341,16 @@ SelfCheckManager.prototype.loginPatron = function(barcode, passwd) {
     );
 
     var evt = openils.Event.parse(this.patron);
-    if(evt) {
+    
+    // verify validity of the card used to log in
+    var inactiveCard = false;
+    if(!evt) {
+        var card = this.patron.cards().filter(
+            function(c) { return (c.barcode() == barcode); })[0];
+        inactiveCard = !openils.Util.isTrue(card.active());
+    }
+
+    if(evt || inactiveCard) {
         this.handleAlert(
             dojo.string.substitute(localeStrings.LOGIN_FAILED, [barcode]),
             false, 'login-failure'