From: James Fournie <jfournie@vcc.ca>
Date: Thu, 17 Jan 2019 21:23:12 +0000 (-0800)
Subject: LP1783421 - Make Copy Alerts permission not global
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=2390eba169637fd18c6682a5ddcd6d136edc06ea;p=working%2FEvergreen.git

LP1783421 - Make Copy Alerts permission not global

For some reason copy alerts require global permissions.  Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.

Signed-off-by: James Fournie <jfournie@vcc.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
---

diff --git a/Open-ILS/examples/fm_IDL.xml b/Open-ILS/examples/fm_IDL.xml
index c883f47c86..f8fc0eaad0 100644
--- a/Open-ILS/examples/fm_IDL.xml
+++ b/Open-ILS/examples/fm_IDL.xml
@@ -7588,10 +7588,18 @@ SELECT  usr,
 		</links>
         <permacrud xmlns="http://open-ils.org/spec/opensrf/IDL/permacrud/v1">
             <actions>
-                <create permission="ADMIN_COPY_ALERT CREATE_COPY_ALERT" global_required="true"/>
-                <retrieve permission="ADMIN_COPY_ALERT VIEW_COPY_ALERT" global_required="true"/>
-                <update permission="ADMIN_COPY_ALERT UPDATE_COPY_ALERT" global_required="true"/>
-                <delete permission="ADMIN_COPY_ALERT DELETE_COPY_ALERT" global_required="true"/>
+                <create permission="ADMIN_COPY_ALERT CREATE_COPY_ALERT">
+                    <context link="copy" field="circ_lib"/>
+                </create>
+                <retrieve permission="ADMIN_COPY_ALERT VIEW_COPY_ALERT">
+                    <context link="copy" field="circ_lib"/>
+				</retrieve>
+                <update permission="ADMIN_COPY_ALERT UPDATE_COPY_ALERT">
+                    <context link="copy" field="circ_lib"/>
+				</update>
+                <delete permission="ADMIN_COPY_ALERT DELETE_COPY_ALERT">
+                    <context link="copy" field="circ_lib"/>
+				</delete>
             </actions>
         </permacrud>
 	</class>
@@ -7616,10 +7624,18 @@ SELECT  usr,
 		</links>
         <permacrud xmlns="http://open-ils.org/spec/opensrf/IDL/permacrud/v1">
             <actions>
-                <create permission="ADMIN_COPY_ALERT CREATE_COPY_ALERT" global_required="true"/>
-                <retrieve permission="ADMIN_COPY_ALERT VIEW_COPY_ALERT" global_required="true"/>
-                <update permission="ADMIN_COPY_ALERT UPDATE_COPY_ALERT" global_required="true"/>
-                <delete permission="ADMIN_COPY_ALERT DELETE_COPY_ALERT" global_required="true"/>
+                <create permission="ADMIN_COPY_ALERT CREATE_COPY_ALERT">
+                    <context link="copy" field="circ_lib"/>
+                </create>
+                <retrieve permission="ADMIN_COPY_ALERT VIEW_COPY_ALERT">
+                    <context link="copy" field="circ_lib"/>
+				</retrieve>
+                <update permission="ADMIN_COPY_ALERT UPDATE_COPY_ALERT">
+                    <context link="copy" field="circ_lib"/>
+				</update>
+                <delete permission="ADMIN_COPY_ALERT DELETE_COPY_ALERT">
+                    <context link="copy" field="circ_lib"/>
+				</delete>
             </actions>
         </permacrud>
 	</class>