From: Jason Stephenson <jason@sigio.com>
Date: Tue, 22 Nov 2016 19:53:07 +0000 (-0500)
Subject: LP 1473054: No-op Checkin Should Not Float a Floating Copy.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=273222f504e83e332880e96ce1a87acd67f11196;p=working%2FEvergreen.git

LP 1473054: No-op Checkin Should Not Float a Floating Copy.

Prior to this patch, a no-op checkin would not check if a copy should
float using the evergreen.can_float() function.  It would simply float
the copy to the org_unit where the checkin happened if the copy had a
float value set.

This commit changes the behavior of no-op checkin to never float a
floating copy, thus considering floating as another operation that
should be skipped on a no-op checkin.

Signed-off-by: Jason Stephenson <jason@sigio.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 8daab0cb9e..04607603f1 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -2604,12 +2604,6 @@ sub do_checkin {
                 }
             }
         }
-    } else { # no-op checkin
-        if ($U->is_true( $self->copy->floating )) { # XXX floating items still stick where they are even with no-op checkin?
-            $self->checkin_changed(1);
-            $self->copy->circ_lib( $self->circ_lib );
-            $self->update_copy;
-        }
     }
 
     if($self->claims_never_checked_out and