From: Dan Scott <dscott@laurentian.ca>
Date: Fri, 2 Dec 2011 04:06:50 +0000 (-0500)
Subject: LP881774: Missing schema on function in 2.0-2.1 upgrade
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=27d6d7a7c05ca944de70f1f033c9333c3ed5128e;p=evergreen%2Fmasslnc.git

LP881774: Missing schema on function in 2.0-2.1 upgrade

Although the search path is altered to include the evergreen schema at
the start of the upgrade, one of the functions in the evergreen schema
does not resolve when invoked without the explicit schema later in the
upgrade script. We address that superficial (but failure provoking / time
wasting) problem by qualifying the function with the evergreen schema in
this commit, but we should also find out why the altered search path
does not seem to be functioning in the upgrade script.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
---

diff --git a/Open-ILS/src/sql/Pg/version-upgrade/2.0-2.1-upgrade-db.sql b/Open-ILS/src/sql/Pg/version-upgrade/2.0-2.1-upgrade-db.sql
index 4c9686f82b..7e874d87f8 100644
--- a/Open-ILS/src/sql/Pg/version-upgrade/2.0-2.1-upgrade-db.sql
+++ b/Open-ILS/src/sql/Pg/version-upgrade/2.0-2.1-upgrade-db.sql
@@ -6916,7 +6916,7 @@ CREATE OR REPLACE FUNCTION unapi.holdings_xml (bid BIGINT, ouid INT, org TEXT, d
                  XMLELEMENT(
                      name volumes,
                      (SELECT XMLAGG(acn) FROM (
-                        SELECT  unapi.acn(acn.id,'xml','volume',array_remove_item_by_value( evergreen.array_remove_item_by_value($5,'holdings_xml'),'bre'), $3, $4, $6, $7, FALSE)
+                        SELECT  unapi.acn(acn.id,'xml','volume', evergreen.array_remove_item_by_value( evergreen.array_remove_item_by_value($5,'holdings_xml'),'bre'), $3, $4, $6, $7, FALSE)
                           FROM  asset.call_number acn
                           WHERE acn.record = $1
                                 AND EXISTS (