From: Galen Charlton <gmc@esilibrary.com>
Date: Tue, 22 Mar 2016 17:45:58 +0000 (-0400)
Subject: LP#1549505: avoid doubling of the 'sort' CGI parameter
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=28f0bbf8e778d116eb8f3306482282f283da0d47;p=working%2FEvergreen.git

LP#1549505: avoid doubling of the 'sort' CGI parameter

This patch ensures that the hidden input to set
the default sort value doesn't get applied to the results
page, which already supplied a widget for the purpose.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
---

diff --git a/Open-ILS/src/templates/opac/parts/searchbar.tt2 b/Open-ILS/src/templates/opac/parts/searchbar.tt2
index 3c93b42f86..53ee4bcf21 100644
--- a/Open-ILS/src/templates/opac/parts/searchbar.tt2
+++ b/Open-ILS/src/templates/opac/parts/searchbar.tt2
@@ -100,10 +100,12 @@
         [% END %]
     </div>
     [%- END %]
-    [% IF NOT CGI.param('sort').defined AND ctx.default_sort %]
-    <input type="hidden" name="sort" value="[% ctx.default_sort %]"/>
+    [% UNLESS took_care_of_form %]
+        [% IF NOT CGI.param('sort').defined AND ctx.default_sort %]
+            <input type="hidden" name="sort" value="[% ctx.default_sort %]"/>
+        [% END %]
+        </form>
     [% END %]
-    [% UNLESS took_care_of_form %]</form>[% END %]
     [% IF (is_advanced AND NOT is_special) AND CGI.param('qtype') %]
     <div class="opac-auto-102">
         [ <a href="[% mkurl(ctx.opac_root _ '/advanced') %]" rel="nofollow" vocab="">[%