From: Mike Rylander <miker@esilibrary.com>
Date: Tue, 21 Jan 2014 18:29:43 +0000 (-0500)
Subject: Need to protect against null values for sorters
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=2ce8f8a1ad7592ef5e272ad301691cb7c85f1d2b;p=working%2FEvergreen.git

Need to protect against null values for sorters

Signed-off-by: Mike Rylander <miker@esilibrary.com>
---

diff --git a/Open-ILS/src/sql/Pg/030.schema.metabib.sql b/Open-ILS/src/sql/Pg/030.schema.metabib.sql
index ad9943aa61..2ab787dcd1 100644
--- a/Open-ILS/src/sql/Pg/030.schema.metabib.sql
+++ b/Open-ILS/src/sql/Pg/030.schema.metabib.sql
@@ -1539,7 +1539,7 @@ BEGIN
             attr_vector := attr_vector || attr_vector_tmp;
         END IF;
 
-        IF attr_def.sorter THEN
+        IF attr_def.sorter AND norm_attr_value[1] IS NOT NULL THEN
             DELETE FROM metabib.record_sorter WHERE source = rid AND attr = attr_def.name;
             INSERT INTO metabib.record_sorter (source, attr, value) VALUES (rid, attr_def.name, norm_attr_value[1]);
         END IF;
diff --git a/Open-ILS/src/sql/Pg/upgrade/YYYY.schema.CRA.sql b/Open-ILS/src/sql/Pg/upgrade/YYYY.schema.CRA.sql
index cdc3e78ad2..9fae927991 100644
--- a/Open-ILS/src/sql/Pg/upgrade/YYYY.schema.CRA.sql
+++ b/Open-ILS/src/sql/Pg/upgrade/YYYY.schema.CRA.sql
@@ -224,7 +224,7 @@ BEGIN
             attr_vector := attr_vector || attr_vector_tmp;
         END IF;
 
-        IF attr_def.sorter THEN
+        IF attr_def.sorter AND norm_attr_value[1] IS NOT NULL THEN
             DELETE FROM metabib.record_sorter WHERE source = rid AND attr = attr_def.name;
             INSERT INTO metabib.record_sorter (source, attr, value) VALUES (rid, attr_def.name, norm_attr_value[1]);
         END IF;