From: Bill Erickson <berick@esilibrary.com>
Date: Thu, 9 Aug 2012 16:57:32 +0000 (-0400)
Subject: URLVerify.pm; apply timeout to lwp useragent; comments
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=2d787a13b4ca0aa93d98a63c5593252a6e1358ee;p=evergreen%2Fequinox.git

URLVerify.pm; apply timeout to lwp useragent; comments

Signed-off-by: Bill Erickson <berick@esilibrary.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/URLVerify.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/URLVerify.pm
index 60c6e19e02..adb4c02d23 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/URLVerify.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/URLVerify.pm
@@ -439,8 +439,12 @@ sub verify_one_url {
     $ENV{FTP_PASSIVE} = 1; # TODO: setting?
 
     my $ua = LWP::UserAgent->new(ssl_opts => {verify_hostname => 0}); # TODO: verify_hostname setting?
+    $ua->timeout($timeout);
+
     my $req = HTTP::Request->new(HEAD => $url->full_url);
-    my $res = $ua->simple_request($req); # avoid auto-redirect
+
+    # simple_request avoids LWP's auto-redirect magic
+    my $res = $ua->simple_request($req); 
 
     $logger->info(sprintf(
         "url: received HTTP '%s' / '%s' [%s]",