From: Jason Boyer <jboyer@library.in.gov>
Date: Mon, 28 Jan 2019 14:45:35 +0000 (-0500)
Subject: LP1796945: More Accurate Joins in AngularJS IDL
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=2f0d4c8447d1d8ebcf77a6e98bd05f3fb84cd77b;p=evergreen%2Fpines.git

LP1796945: More Accurate Joins in AngularJS IDL

Currently all joins of all classes are hard-coded to
inner, which is clearly sub-optimal. This branch
tries to correct this by looking at the reltype param
on links.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
---

diff --git a/Open-ILS/web/js/ui/default/staff/services/idl.js b/Open-ILS/web/js/ui/default/staff/services/idl.js
index 629e5958e0..a5fe5f23a2 100644
--- a/Open-ILS/web/js/ui/default/staff/services/idl.js
+++ b/Open-ILS/web/js/ui/default/staff/services/idl.js
@@ -328,7 +328,7 @@ angular.module('egCoreMod')
 
         return angular.extend( args, {
             idl     : service[cls],
-            jtype   : 'inner',
+            jtype   : (args.link && args.link.reltype == 'has_a') ? 'inner' : 'left',
             uplink  : args.link,
             classname: cls,
             struct  : n,