From: Jason Boyer <JBoyer@library.in.gov>
Date: Fri, 1 Sep 2017 21:09:36 +0000 (-0400)
Subject: LP1714589: Use Explicit Definition for aacs
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=31d6a99dc99af41eda8b6ed4797bb230aabcae2f;p=working%2FEvergreen.git

LP1714589: Use Explicit Definition for aacs

Spell out the expected fields in the expected order
for the aacs view because databases that have undergone
upgrades may drift when using * in a UNION.

Signed-off-by:  <JBoyer@library.in.gov>
---

diff --git a/Open-ILS/src/sql/Pg/upgrade/1051.schema.all-circs-slim.sql b/Open-ILS/src/sql/Pg/upgrade/1051.schema.all-circs-slim.sql
index 71c22f199a..5a412753c9 100644
--- a/Open-ILS/src/sql/Pg/upgrade/1051.schema.all-circs-slim.sql
+++ b/Open-ILS/src/sql/Pg/upgrade/1051.schema.all-circs-slim.sql
@@ -3,7 +3,40 @@ BEGIN;
 SELECT evergreen.upgrade_deps_block_check('1051', :eg_version);
 
 CREATE OR REPLACE VIEW action.all_circulation_slim AS
-    SELECT * FROM action.circulation
+    SELECT
+        id,
+        usr,
+        xact_start,
+        xact_finish,
+        unrecovered,
+        target_copy,
+        circ_lib,
+        circ_staff,
+        checkin_staff,
+        checkin_lib,
+        renewal_remaining,
+        grace_period,
+        due_date,
+        stop_fines_time,
+        checkin_time,
+        create_time,
+        duration,
+        fine_interval,
+        recurring_fine,
+        max_fine,
+        phone_renewal,
+        desk_renewal,
+        opac_renewal,
+        duration_rule,
+        recurring_fine_rule,
+        max_fine_rule,
+        stop_fines,
+        workstation,
+        checkin_workstation,
+        copy_location,
+        checkin_scan_time,
+        parent_circ
+    FROM action.circulation
 UNION ALL
     SELECT
         id,