From: Garry Collum <gcollum@gmail.com>
Date: Fri, 30 Oct 2020 19:55:35 +0000 (-0400)
Subject: lp1902302 Opac. SMS and Carriers appear in Edit Holds Regardless of OU Setting.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=33c341fb3ed474fc628f832c571d6e53edc91669;p=evergreen%2Fequinox.git
lp1902302 Opac. SMS and Carriers appear in Edit Holds Regardless of OU Setting.
The SMS Number field and Default Carrier field display when editing an
individual hold in the opac, regardless of the 'Enable features that send SMS text messages' setting.
This patch rectifies that behavior.
To test.
Set the 'Enable features that send SMS text messages' to False.
Place a hold for a patron.
Login to the opac as that patron and view the holds.
Edit the hold, and notice that the SMS and Carrier fields are displayed.
Apply the patch.
Refresh the edit form. The fields no longer display.
Set the 'Enable features that send SMS text messages' to True.
Refresh the edit form. The fields now display.
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---
diff --git a/Open-ILS/src/templates/opac/myopac/holds/edit.tt2 b/Open-ILS/src/templates/opac/myopac/holds/edit.tt2
index ab8737339e..1d1d7cdf22 100644
--- a/Open-ILS/src/templates/opac/myopac/holds/edit.tt2
+++ b/Open-ILS/src/templates/opac/myopac/holds/edit.tt2
@@ -111,6 +111,7 @@
<td><input type="text" name="phone_notify"
value="[% ahr.phone_notify | html %]" /></td>
</tr>
+ [% IF ctx.get_org_setting(ctx.search_ou, 'sms.enable') == 1%]
<tr>
<td>[% l('SMS Notification') %]</td>
<td><input onblur="check_sms_carrier(event)" type="text" name="sms_notify"
@@ -120,6 +121,7 @@
<td>[% l('Default Mobile Carrier') %]</td>
<td>[% INCLUDE "opac/parts/sms_carrier_selector.tt2" ahr, sms_carrier_hide_warning="true", sms_carrier_hide_label="true" %]</td>
</tr>
+ [% END %]
[% END %]
<tr><td colspan='4'>