From: erickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Sat, 3 Nov 2007 18:59:05 +0000 (+0000)
Subject: Turned all instances of VOLUME_UPDATE into UPDATE_VOLUME permission checks
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=34db73d4cde9239828b15c0daa219f6284f2f9dc;p=Evergreen.git

Turned all instances of VOLUME_UPDATE into UPDATE_VOLUME permission checks
UPDATE_VOLUME was the original permission and conforms to the permission naming scheme
no longer creating the VOLUME_UPDATE permission in the DB




git-svn-id: svn://svn.open-ils.org/ILS/trunk@7972 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm b/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
index 42220d270f..d22911d992 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
@@ -1296,7 +1296,7 @@ sub batch_volume_transfer {
 
 	my $e = new_editor(authtoken => $auth, xact =>1);
 	return $e->event unless $e->checkauth;
-	return $e->event unless $e->allowed('VOLUME_UPDATE', $o_lib);
+	return $e->event unless $e->allowed('UPDATE_VOLUME', $o_lib);
 
 	my $dorg = $e->retrieve_actor_org_unit($o_lib)
 		or return $e->event;
@@ -1477,7 +1477,7 @@ sub find_or_create_volume {
 	# Otherwise, create a new volume with the given attributes
 	# -----------------------------------------------------------------
 
-	return $e->die_event unless $e->allowed('VOLUME_UPDATE', $org_id);
+	return $e->die_event unless $e->allowed('UPDATE_VOLUME', $org_id);
 
 	$vol = Fieldmapper::asset::call_number->new;
 	$vol->owning_lib($org_id);
diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Cat/Merge.pm b/Open-ILS/src/perlmods/OpenILS/Application/Cat/Merge.pm
index 9804fb2962..77e596cba9 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Cat/Merge.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Cat/Merge.pm
@@ -217,7 +217,7 @@ sub merge_volumes {
 		$_->deleted('t');
 		$_->editor($editor->requestor->id);
 		$_->edit_date('now');
-		return (undef,$editor->event) unless $editor->allowed('VOLUME_UPDATE', $_->owning_lib);
+		return (undef,$editor->event) unless $editor->allowed('UPDATE_VOLUME', $_->owning_lib);
 		$editor->update_asset_call_number($_) or return (undef, $editor->event);
 	}
 
diff --git a/Open-ILS/src/sql/Pg/006.data.permissions.sql b/Open-ILS/src/sql/Pg/006.data.permissions.sql
index 86e8b046a1..f312cfdc4a 100644
--- a/Open-ILS/src/sql/Pg/006.data.permissions.sql
+++ b/Open-ILS/src/sql/Pg/006.data.permissions.sql
@@ -138,7 +138,6 @@ INSERT INTO permission.perm_list VALUES (141, 'PATRON_EXCEEDS_FINES.override', '
 INSERT INTO permission.perm_list VALUES (142, 'CIRC_EXCEEDS_COPY_RANGE.override', '');
 INSERT INTO permission.perm_list VALUES (143, 'ITEM_ON_HOLDS_SHELF.override', '');
 INSERT INTO permission.perm_list VALUES (144, 'COPY_NOT_AVAILABLE.override', 'Allow staff to force checkout of Missing/Lost type items');
-INSERT INTO permission.perm_list VALUES (145, 'VOLUME_UPDATE', '');
 INSERT INTO permission.perm_list VALUES (146, 'HOLD_EXISTS.override', 'allows users to place multiple holds on a single title');
 INSERT INTO permission.perm_list VALUES (147, 'RUN_REPORTS', 'Allows a users to run reports');
 INSERT INTO permission.perm_list VALUES (148, 'SHARE_REPORT_FOLDER', 'Allows a user to share report his own folders');