From: Bill Erickson <berickxx@gmail.com>
Date: Mon, 15 Dec 2014 20:08:06 +0000 (-0500)
Subject: Holds placement avoid calling non-existent func.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=34dc5f91652c03a294360883413891f042e39f9b;p=working%2FEvergreen.git

Holds placement avoid calling non-existent func.

Avoid calling an undefined function during hold placement.  In older
versions of opensrf, this kind of the thing would silently fail.  (Well,
it would log to the stderr file).  Modern opensrf allows Perl the throw
a standard exception, which stops execution.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
index b853b427d8..7d405abb62 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
@@ -396,7 +396,7 @@ sub create_hold {
         'open-ils.hold-targeter.target', {hold => $hold->id}
     ) unless $U->is_true($hold->frozen);
 
-    $U->log_user_activity($recipient->id, $self->get_act_who, 'hold');
+    $U->log_user_activity($recipient->id, '', 'hold');
     return undef;
 }