From: Bill Erickson <berick@esilibrary.com>
Date: Mon, 3 Mar 2014 16:08:54 +0000 (-0500)
Subject: LP#1284864 MR display avoid fetching master
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=3bd56efa634f801972a32879ca8910fc6c35e9e6;p=evergreen%2Fpines.git

LP#1284864 MR display avoid fetching master

Remove unnecessary code to fetch the MR master when compiling MR
constituent records lists, since the master record was slipping into the
results set, where it should not have been.  This code is unneeded and
is a holdover from an earlier experiment.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
index a42ad093e5..955fce3ce1 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
@@ -469,18 +469,6 @@ sub load_rresults {
 
     my $fetch_recs = $rec_ids;
 
-    my $metarecord_master;
-    if ($metarecord) {
-        # when listing the contents of a metarecord, be sure to fetch
-        # the lead record for summary display.  Adding the ID to
-        # $fetch_recs lets us grab the record (if necessary) w/o it
-        # unintentially becoming a member of the result set.
-        my $mr = $e->retrieve_metabib_metarecord($metarecord);
-        push(@$fetch_recs, $mr->master_record)
-            unless grep {$_ eq $mr->master_record} @$fetch_recs;
-        $metarecord_master = $mr->master_record;
-    }
-
     $self->timelog("Calling get_records_and_facets()");
     my ($facets, @data) = $self->get_records_and_facets(
         $fetch_recs, $results->{facet_key}, 
@@ -516,9 +504,6 @@ sub load_rresults {
         my ($rec) = grep { $_->{$id_key} == $rec_id } @data;
         push(@{$ctx->{records}}, $rec);
 
-        $ctx->{metarecord_master} = $rec
-            if $metarecord_master and $metarecord_master eq $rec_id;
-
         if ($is_meta) {
             # collect filtered, constituent records count for each MR
             my $bre_ids = $self->recs_from_metarecord(