From: Jeff Davis <jeff.davis@bc.libraries.coop>
Date: Thu, 4 May 2023 18:13:42 +0000 (-0700)
Subject: LP#2018534: treat year as numeric when retrieving item circs by year
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=3d1610d25a2812252aa5b8648caf3eff6d0ec3a1;p=Evergreen.git

LP#2018534: treat year as numeric when retrieving item circs by year

The open-ils.pcrud.search.circbyyr API uses EXTRACT to extract the year
from circulation timestamps.  In recent versions of Postgres, the return
type for EXTRACT was changed from double precision to numeric (thanks to
Jason Boyer for noticing this!); for obscure reasons, this causes pcrud
to return the year as a string instead of a number.  So, let's get the
staff client to force those values to be numbers before doing math with
them.

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/web/js/ui/default/staff/cat/item/app.js b/Open-ILS/web/js/ui/default/staff/cat/item/app.js
index f7220130bd..4869605bf2 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/item/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/item/app.js
@@ -1129,7 +1129,7 @@ console.debug($scope.copy_alert_count);
 
             $scope.circ_counts = counts.reduce(function(circ_counts, circbyyr) {
                 var count = Number(circbyyr.count());
-                var year = circbyyr.year();
+                var year = Number(circbyyr.year());
 
                 var index = circ_counts.findIndex(function(existing_count) {
                     return existing_count.year === year;