From: Josh Stompro <stompro@stompro.org>
Date: Mon, 4 Mar 2019 14:57:02 +0000 (-0600)
Subject: LP#1667497 - Define $params{depth} to avoid uninitialized warning.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=3e3ec8ec68bdc49eb43a6dedc187c3c90a3813cc;p=working%2FEvergreen.git

LP#1667497 - Define $params{depth} to avoid uninitialized warning.

$depth is set to 0 if $params{depth} is unset, but then $params{depth}
gets used later on, which causes an uninitialized value warning.

So set $params{depth} to whatever $depth was set to.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
index 77868503f3..1e57e9abd0 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
@@ -2381,6 +2381,7 @@ sub check_title_hold {
 
     my %params       = %$params;
     my $depth        = $params{depth}        || 0;
+    $params{depth} = $depth;   #define $params{depth} if unset, since it gets used later
     my $selection_ou = $params{selection_ou} || $params{pickup_lib};
     my $oargs        = $params{oargs}        || {};