From: Remington Steed <rjs7@calvin.edu>
Date: Fri, 29 Aug 2014 18:45:50 +0000 (-0400)
Subject: LP#1361801: Add required fields to serial issuance form
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=3e96e0536624e2ba2fb6515450692fae862c1d7d;p=contrib%2FConifer.git

LP#1361801: Add required fields to serial issuance form

This commit prevents issuances from being created without a date_published
or holding_code. This has two benefits:

  1. Prevents uncaught exceptions related to submitting null values for
     either of those fields.
  2. Requiring date_published prevents an ugly error when trying to
     predict new issuances from an issuance without a date_published.

This commit does NOT provide any feedback to the user about which fields
are required. That would require further investigation into the Dojo/Dijit
objects being used for the edit form fields.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
---

diff --git a/Open-ILS/src/templates/serial/subscription/issuance.tt2 b/Open-ILS/src/templates/serial/subscription/issuance.tt2
index aaa0ee8cb1..a90e5b0cce 100644
--- a/Open-ILS/src/templates/serial/subscription/issuance.tt2
+++ b/Open-ILS/src/templates/serial/subscription/issuance.tt2
@@ -28,6 +28,7 @@
         fmClass="siss"
         query="{id: '*'}"
         editOnEnter="true"
+        requiredFields="['date_published','holding_code']"
         showPaginator="true">
         <thead>
             <tr>