From: Dan Briem <dbriem@wlsmail.org>
Date: Mon, 10 May 2021 02:27:38 +0000 (-0400)
Subject: LP#1892435 Splash page catalog searches don't work with spaces
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=3ff0b30eddd6be4a18c9f31e78fad2836f89f856;p=Evergreen.git

LP#1892435 Splash page catalog searches don't work with spaces

On older versions of Apache's mod_rewrite, splash page catalog
searches are escaped in JavaScript and escaped again during the
redirect to the Angular locale path, so searches with special
characters result in a search that's still encoded.

Test on Ubuntu 16.04.7, Apache 2.4.18, EG 3.6+. A splash page
catalog search for Harry Potter results in a search for
Harry%20Potter.

Add the NE (noescape) flag to the Angular locale path redirect
in /etc/apache2/eg_vhost.conf as indicated in this example file.
A splash page search for Harry Potter then works as expected.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
---

diff --git a/Open-ILS/examples/apache_24/eg_vhost.conf.in b/Open-ILS/examples/apache_24/eg_vhost.conf.in
index 53f411ddb5..a6d07e80ed 100644
--- a/Open-ILS/examples/apache_24/eg_vhost.conf.in
+++ b/Open-ILS/examples/apache_24/eg_vhost.conf.in
@@ -968,13 +968,13 @@ RewriteRule ^/openurl$ ${openurl:%1} [NE,PT]
 #RewriteCond %{REQUEST_URI} ^/eg2/
 #RewriteCond %{REQUEST_URI} !^/eg2/fr-CA/
 #RewriteCond %{HTTP_COOKIE} eg_locale=fr_ca
-#RewriteRule ^/eg2/(.*) https://%{HTTP_HOST}/eg2/fr-CA/$1 [R=307,L]
+#RewriteRule ^/eg2/(.*) https://%{HTTP_HOST}/eg2/fr-CA/$1 [NE,R=307,L]
 
 # Default / en-US.
 # No alternate supported cookie provided.
 RewriteCond %{REQUEST_URI}  ^/eg2/
 RewriteCond %{REQUEST_URI}  !^/eg2/([a-z]{2}-[A-Z]{2})/
-RewriteRule ^/eg2/(.*) https://%{HTTP_HOST}/eg2/en-US/$1 [R=307,L]
+RewriteRule ^/eg2/(.*) https://%{HTTP_HOST}/eg2/en-US/$1 [NE,R=307,L]
 
 # en-US build
 # This is the only required configuration when only using the default locale.