From: Jason Boyer <jboyer@library.in.gov>
Date: Thu, 17 Jan 2019 18:33:10 +0000 (-0500)
Subject: LP1798628: Copy alert counts in Holdings
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=401ec7296128a2d9e8f720352df9e3f4c35ef660;p=contrib%2FConifer.git

LP1798628: Copy alert counts in Holdings

Currently the count of all copy alerts ever applied
to a copy is displayed in the Holdings view, which
can be quite confusing when clicking Manage and not
seeing the expected number of alerts. This branch
changes the display to only count the number of
events currently active since those are the only
ones available to manage.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
---

diff --git a/Open-ILS/web/js/ui/default/staff/cat/services/holdings.js b/Open-ILS/web/js/ui/default/staff/cat/services/holdings.js
index ad16b5d1f2..d78c049bc3 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/services/holdings.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/services/holdings.js
@@ -132,7 +132,9 @@ function(egCore , $q) {
 
                 // create virtual field for copy alert count
                 angular.forEach(svc.copies, function (cp) {
-                    if (cp.copy_alerts) cp.copy_alert_count = cp.copy_alerts.length;
+                    if (cp.copy_alerts) {
+                        cp.copy_alert_count = cp.copy_alerts.filter(function(aca) { return aca.ack_time == null ;}).length;
+                    }
                     else cp.copy_alert_count = 0;
                 });