From: Jason Stephenson <jstephenson@mvlc.org>
Date: Tue, 23 Oct 2012 17:23:14 +0000 (-0400)
Subject: LP#1070466: Pack, then unpack total in debug_split_print.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=40bf68d9e3a6f02ee141aa9ae50cc6e2f7393cee;p=working%2FSIPServer.git

LP#1070466: Pack, then unpack total in debug_split_print.

The checksum needs to be a 16bit value, so we pack, then unpack the
checksum total in debug_split_print to guarantee that.  Some longer
messages have generated 32-bit checksums.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
---

diff --git a/Sip/Checksum.pm b/Sip/Checksum.pm
index 389a0f8..71dd59b 100644
--- a/Sip/Checksum.pm
+++ b/Sip/Checksum.pm
@@ -59,7 +59,8 @@ sub debug_split_print {
         printf STDERR "= %4d\n\n", $subtotal;
     }
     printf STDERR "%56d\n", $total;
-    return $total;
+    # Pack, then upack to make sure we have 16-bit value.
+    return unpack("S", pack("S", $total));
 }