From: Jason Stephenson <jason@sigio.com>
Date: Wed, 18 Dec 2019 18:11:55 +0000 (-0500)
Subject: LP#1856868: Remove deprecated open-ils.circ.renew.auto API
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=4210059afeef91237ff5cb4a33af827df977090a;p=evergreen%2Fmasslnc.git

LP#1856868: Remove deprecated open-ils.circ.renew.auto API

The deprecated open-ils.circ.renew.auto API was removed.  You will
want to use open-ils.circ.renew with the auto_renewal option set
to 1.  This mainly affects those who have written custom code using
the open-ils.circ backend.

This removal was broadcast in the release notes for Launchpad bug
1835085: https://bugs.launchpad.net/bugs/1835085.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 7ac877b069..7a6751df3b 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -120,16 +120,6 @@ __PACKAGE__->register_method(
 );
 
 __PACKAGE__->register_method(
-    method    => "run_method",
-    api_name  => "open-ils.circ.renew.auto",
-    signature => q/@see open-ils.circ.renew/,
-    notes     => q/
-    The open-ils.circ.renew.auto API is deprecated.  Please use the
-    auto_renew => 1 option to open-ils.circ.renew, instead.
-    /
-);
-
-__PACKAGE__->register_method(
     method  => "run_method",
     api_name    => "open-ils.circ.renew",
     notes       => <<"    NOTES");
@@ -243,7 +233,6 @@ sub run_method {
     }
 
     $circulator->is_renewal(1) if $api =~ /renew/;
-    $circulator->auto_renewal(1) if $api =~ /renew.auto/;
     $circulator->is_checkin(1) if $api =~ /checkin/;
     $circulator->is_checkout(1) if $api =~ /checkout/;
     $circulator->override(1) if $api =~ /override/o;
diff --git a/docs/RELEASE_NOTES_NEXT/Circulation/renew-auto-removed.adoc b/docs/RELEASE_NOTES_NEXT/Circulation/renew-auto-removed.adoc
new file mode 100644
index 0000000000..20b845c1d2
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/Circulation/renew-auto-removed.adoc
@@ -0,0 +1,6 @@
+open-ils.circ.renew.auto Removed
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+The deprecated `open-ils.circ.renew.auto` API was removed.  You will
+want to use `open-ils.circ.renew` with the `auto_renewal` option set
+to 1.  This mainly affects those who have written custom code using
+the open-ils.circ backend.