From: Bill Erickson <berickxx@gmail.com>
Date: Mon, 8 Jun 2020 20:03:14 +0000 (-0400)
Subject: LP1882591 Empty combobox avoids default selection
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=435ff7ae7cf503c4c7fc00a23bafd7f939a3312c;p=working%2FEvergreen.git

LP1882591 Empty combobox avoids default selection

When clearing a combobox value, no combobox options are displayed in the
dropdown.  This allows users to clear the value then tab out of the box
without the typeahead magic forcing selection of the first entry.

The full list can still be displayed by clicking on the combobox.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts b/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
index 3f5aab8501..2afbe4105c 100644
--- a/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
+++ b/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
@@ -377,12 +377,13 @@ export class ComboboxComponent implements ControlValueAccessor, OnInit {
             mergeMap(term => this.addAsyncEntries(term)),
             map((term: string) => {
 
-                if (term === '' || term === '_CLICK_') {
-                    if (!this.asyncDataSource) {
-                        // In sync mode, a post-focus empty search or
-                        // click event displays the whole list.
-                        return this.entrylist;
-                    }
+                // Display no values when the input is empty and no
+                // click action occurred.
+                if (term === '') { return []; }
+
+                // In sync-data mode, a click displays the full list.
+                if (term === '_CLICK_' && !this.asyncDataSource) {
+                    return this.entrylist;
                 }
 
                 // Filter entrylist whose labels substring-match the