From: Dan Briem <dbriem@wlsmail.org>
Date: Fri, 17 Jul 2020 20:09:54 +0000 (-0400)
Subject: LP#1887852 Pending patron passwords aren't initially set to phone #
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=46603396a83c58275c77ca8329f91d54ffc6d375;p=working%2FEvergreen.git

LP#1887852 Pending patron passwords aren't initially set to phone #

If a patron self registers with a phone # and the org unit
setting to use the phone for the password is true, when the
pending patron stage loads the password is initially random
instead of the last 4 digits of the phone #.

This branch sets the password to the last 4 digits of the phone
when the patron stage loads if the phone is set and the org
unit setting to use the phone # for the password is true.

To test:
1. Set org unit settings for allow patron self-registration and
   show day_phone on registration to true
2. Go to the OPAC and request a library card (include phone #)
3. Login to the staff client, Circulation->Pending Patrons and
   load the patron
4. Note the password is random
5. Load patch and repeat steps 3-4
6. Note the password is the last 4 digits of the phone #

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jason Stephenson <jason@sigio.com>
---

diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
index 6a2a648d7d..0d6394db55 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
@@ -1305,7 +1305,12 @@ function($scope , $routeParams , $q , $uibModal , $window , egCore ,
     function set_new_patron_defaults(prs) {
         if (!$scope.patron.passwd) {
             // passsword may originate from staged user.
-            $scope.generate_password();
+            if ($scope.patron.day_phone &&
+                $scope.org_settings['patron.password.use_phone']) {
+                $scope.patron.passwd = $scope.patron.day_phone.substr(-4);
+            } else {
+                $scope.generate_password();
+            }
         }
 
         var notify = 'phone:email'; // hard-coded default when opac.hold_notify has no reg_default