From: Dan Pearl <dpearl@cwmars.org>
Date: Tue, 10 Apr 2018 18:45:47 +0000 (-0400)
Subject: LP1760893 Add Holdings Part dropdown should list items in order
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=4701869d8e4a1fd57b2ee1c1600b56a98e962e09;p=evergreen%2Ftadl.git

LP1760893 Add Holdings Part dropdown should list items in order

Without a defined sort, the Part dropdown when editing a holding simply
displays in database order.  Let's be more deterministic about it.

In this case, while slightly surprising, consensus opinion was that
reverse order on label_sortkey provides the best overall usability.
This is obviously true on records with many parts, but can help in all
cases.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
---

diff --git a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
index a9c28c976e..c27170ac43 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
@@ -272,7 +272,8 @@ function(egCore , $q) {
 
         return egCore.pcrud.search('bmp',
             {record : rec, deleted : 'f'},
-            null, {atomic : true}
+            {order_by: {bmp : 'label_sortkey DESC'}},
+            {atomic : true}
         ).then(function(list) {
             service.bmp_parts[rec] = list;
             return list;