From: Jason Stephenson <jason@sigio.com>
Date: Tue, 18 Dec 2018 14:26:11 +0000 (-0500)
Subject: Lp 1752968: Select content when focusing on the barcode field.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=4811789259dab5dcd11be9817a8e720680ba0891;p=Evergreen.git

Lp 1752968: Select content when focusing on the barcode field.

To reproduce the reported behavior:

 1. Find a title in the staff client catalog.
 2. Click on Add Holdings.
 3. See that the Barcode field does not have cursor focus.
 4. Repeat step 1.
 5. Click on edit next to one of the barcoded items in the list of
    holdings.
 6. Click Show Holdings Details and see that the Barcode field does
     not have focus and the content is not selected.

To test this branch:

 1. Find a title in the staff client catalog.
 2. Click on Add Holdings.
 3. See that the Barcode field has cursor focus, i.e. the cursor is in
    the field and blinking.
 4. Repeat step 1.
 5. Click on edit next to one of the barcoded items in the list of
    holdings.
 6. Click Show Holdings Details and see that the Barcode field has
     cursor focus and the content is selected/highlighted.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
---

diff --git a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
index 2b8d301bb3..1fb9da6ab1 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
@@ -489,7 +489,7 @@ function(egCore , $q) {
                     '<input id="{{callNumber.id()}}_{{copy.id()}}"'+
                     ' eg-enter="nextBarcode(copy.id())" class="form-control"'+
                     ' type="text" ng-model="barcode" ng-change="updateBarcode()"'+
-                    ' autofocus/>'+
+                    ' ng-focus="selectOnFocus($event)" autofocus/>'+
                     '<div class="label label-danger" ng-if="duplicate_barcode">{{duplicate_barcode_string}}</div>'+
                     '<div class="label label-danger" ng-if="empty_barcode">{{empty_barcode_string}}</div>'+
                 '</div>'+
@@ -509,6 +509,11 @@ function(egCore , $q) {
 
                 if (!$scope.copy.barcode()) $scope.copy.empty_barcode = true;
 
+                $scope.selectOnFocus = function($event) {
+                    if (!$scope.copy.empty_barcode)
+                        $event.target.select();
+                }
+
                 $scope.nextBarcode = function (i) {
                     $scope.focusNext(i, $scope.barcode);
                 }