From: erickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Mon, 2 Oct 2006 14:48:14 +0000 (+0000)
Subject: fixed logic error in volume merge
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=484ff95f0db5104cd1378be55926c48cbcd6aee4;p=Evergreen.git

fixed logic error in volume merge


git-svn-id: svn://svn.open-ils.org/ILS/trunk@6353 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm b/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
index c9f1ba5e27..3523fea58d 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
@@ -1306,7 +1306,7 @@ sub batch_volume_transfer {
 				$logger->debug("merge: searching for copies with remote circ_lib for volume ".$v->id);
 				my $args = { 
 					call_number	=> $v->id, 
-					circ_lib		=> { "!=" => $v->owning_lib },
+					circ_lib		=> { "not in" => [ $o_lib, $v->owning_lib ] },
 					deleted		=> 'f'
 				};
 
@@ -1314,7 +1314,6 @@ sub batch_volume_transfer {
 
 				# if the copy's circ_lib matches the destination lib,
 				# that's ok too
-				$copies = [ grep { $_->circ_lib ne $o_lib } @$copies ];
 				return OpenILS::Event->new('COPY_REMOTE_CIRC_LIB') if @$copies;
 			}
 		}