From: Bill Erickson <berickxx@gmail.com>
Date: Fri, 25 Jun 2021 19:45:39 +0000 (-0400)
Subject: LP1891369 Renewal exentions ignores overdues
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=48e0f2408e782703517c1d310c630107f8ada04f;p=working%2FEvergreen.git

LP1891369 Renewal exentions ignores overdues

Exit renewal extension logic early when the renewed circulation was
overdue.  I.e., there's no time to offer on the subsequent circulation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 0b6c0f8c66..0a06011eed 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -2388,11 +2388,13 @@ sub extend_renewal_due_date {
     my $start_time = DateTime::Format::ISO8601->new
         ->parse_datetime(clean_ISO8601($prev_circ->xact_start))->epoch;
 
-    my $end_time = DateTime::Format::ISO8601->new
+    my $due_time = DateTime::Format::ISO8601->new
         ->parse_datetime(clean_ISO8601($prev_circ->due_date))->epoch;
 
     my $now_time = DateTime->now->epoch;
 
+    return if $due_time < $now_time; # Renewed circ was overdue.
+
     if (my $interval = $matchpoint->renew_extend_min_interval) {
 
         my $min_duration = OpenILS::Utils::DateTime->interval_to_seconds($interval);
@@ -2401,7 +2403,7 @@ sub extend_renewal_due_date {
         return if $checkout_duration < $min_duration;
     }
 
-    my $remaining_duration = $end_time - $now_time;
+    my $remaining_duration = $due_time - $now_time;
 
     my $due_date = DateTime::Format::ISO8601->new
         ->parse_datetime(clean_ISO8601($circ->due_date));