From: Jason Boyer <JBoyer@eoli.info>
Date: Tue, 22 Oct 2019 16:51:15 +0000 (-0400)
Subject: LP1845693: Test Angular(JS) with modern browsers
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=4aae34685d548c0058d739aaaf1cfd9f881b2117;p=evergreen%2Fpines.git

LP1845693: Test Angular(JS) with modern browsers

Rather than using PhantomJS to test Angular(JS),
we can use all supported browsers for the web client.
Currently this is Firefox and Chrom(ium).

Because of the number of dependencies this also
requires that testing is removed from the standard
build instructions and only done in specific testing
environments or on developer machines.

Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/src/eg2/package.json b/Open-ILS/src/eg2/package.json
index c2d9e8e528..2bb3143d07 100644
--- a/Open-ILS/src/eg2/package.json
+++ b/Open-ILS/src/eg2/package.json
@@ -49,10 +49,10 @@
     "jasmine-spec-reporter": "^4.2.1",
     "karma": "^4.4.1",
     "karma-chrome-launcher": "^3.1.0",
+    "karma-firefox-launcher": "^1.2.0",
     "karma-coverage-istanbul-reporter": "^2.1.0",
     "karma-jasmine": "^2.0.1",
     "karma-jasmine-html-reporter": "^1.4.2",
-    "karma-phantomjs-launcher": "^1.0.4",
     "ngx-i18nsupport": "^0.17.1",
     "protractor": "^5.4.2",
     "ts-node": "^8.4.1",
diff --git a/docs/installation/server_installation.adoc b/docs/installation/server_installation.adoc
index e2a93a9c2a..c703fc1db1 100644
--- a/docs/installation/server_installation.adoc
+++ b/docs/installation/server_installation.adoc
@@ -121,8 +121,19 @@ Extra steps for web staff client
 
 [NOTE]
 Skip this entire section if you are using an official release tarball downloaded
-from http://evergreen-ils.org/downloads. Otherwise, ensure you have installed the
-<<optional_developer_additions,optional developer additions>> before proceeding.
+from http://evergreen-ils.org/downloads
+
+Install dependencies for web staff client
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+[NOTE]
+You may skip this section if you have installed the
+<<optional_developer_additions,optional developer additions>>.  You will still need to do the following
+steps in <<install_files_for_web_staff_client,Install files for web staff client>>.
+
+1. Install the long-term stability (LTS) release of
+https://nodejs.org[Node.js]. Add the Node.js `/bin` directory to your
+environment variable `PATH`.
 
 [[install_files_for_web_staff_client]]
 Install AngularJS files for web staff client
@@ -152,9 +163,7 @@ npm install   # fetch JS dependencies
 npm run build-prod
 ------------------------------------------------------------------------------
 +
-4. OPTIONAL: Test web client code if the <osname>-developer packages were installed.
-   CHROME_BIN should be set to the path to chrome or chromimum, e.g.,
-   `/usr/bin/chromium`:
+4. OPTIONAL: Test web client code if the <osname>-developer packages were installed
 +
 [source,sh]
 ------------------------------------------------------------------------------
@@ -189,9 +198,7 @@ npm install   # fetch JS dependencies
 ng build --prod
 ------------------------------------------------------------------------------
 +
-4. OPTIONAL: Test eg2 web client code if the <osname>-developer packages were installed:
-   CHROME_BIN should be set to the path to chrome or chromimum, e.g.,
-   `/usr/bin/chromium`:
+4. OPTIONAL: Test eg2 web client code if the <osname>-developer packages were installed
 +
 [source,sh]
 ------------------------------------------------------------------------------