From: Chris Sharp <csharp@georgialibraries.org>
Date: Tue, 31 Jan 2023 19:59:18 +0000 (-0500)
Subject: LP#2004420: check that $note is defined before using it
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=5358821f40966620f33e0dc912d811c60a9327b5;p=working%2FEvergreen.git

LP#2004420: check that $note is defined before using it

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
index c72072c87f..00e042a87a 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
@@ -949,9 +949,10 @@ sub void_bills {
         $bill->voided('t');
         $bill->voider($e->requestor->id);
         $bill->void_time('now');
-        my $n = ($bill->note) ? sprintf("%s\n", $bill->note) : "";
-        $bill->note(sprintf("$n%s", $note));
-
+        if (defined $note) { # only do this if there's a $note to add
+            my $n = ($bill->note) ? sprintf("%s\n", $bill->note) : "";
+            $bill->note(sprintf("$n%s", $note));
+        }
         $e->update_money_billing($bill) or return $e->die_event;
         my $evt = $U->check_open_xact($e, $bill->xact, $xact);
         return $evt if $evt;