From: Remington Steed <rjs7@calvin.edu>
Date: Tue, 30 Jul 2019 19:52:39 +0000 (-0400)
Subject: LP#1761222: Replace bib "quality" with item "mint_condition"
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=559541a5506776ba1b47d18b151e38b1f938dd9f;p=contrib%2FConifer.git

LP#1761222: Replace bib "quality" with item "mint_condition"

I originally misunderstood the XUL item field labeled "quality" and
pulled in the bib record "overall quality" score. But upon checking the
XUL holdings maintenance screen again, we clearly want the item's
"mint_condition" field instead. This commit makes that correction and
converts the 't' or 'f' values into "Good" or "Damaged", to match the
item editor labels.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
---

diff --git a/Open-ILS/src/templates/staff/cat/catalog/t_holdings.tt2 b/Open-ILS/src/templates/staff/cat/catalog/t_holdings.tt2
index 3d827ddac5..8b77183b20 100644
--- a/Open-ILS/src/templates/staff/cat/catalog/t_holdings.tt2
+++ b/Open-ILS/src/templates/staff/cat/catalog/t_holdings.tt2
@@ -141,7 +141,9 @@
     <eg-grid-field label="[% l('Classification') %]"          path="call_number.label_class.name" hidden></eg-grid-field>
     <eg-grid-field label="[% l('Due Date') %]"                path="_circ.due_date" datecontext="_circ_lib" dateonlyinterval="_duration" datatype="timestamp" visible></eg-grid-field>
     <eg-grid-field label="[% l('OPAC Visible?') %]"           datatype="bool" path="opac_visible" hidden></eg-grid-field>
-    <eg-grid-field label="[% l('Quality') %]"                 path="call_number.record.simple_record.quality" hidden></eg-grid-field>
+    <eg-grid-field label="[% l('Quality') %]"                 path="mint_condition" hidden>
+      <span>{{ item['mint_condition']=='t' ? '[% l('Good') %]' : '[% l('Damaged') %]' }}</span>
+    </eg-grid-field>
   
   </eg-grid>
 </div>