From: Kathy Lussier <klussier@masslnc.org>
Date: Tue, 24 May 2016 00:09:34 +0000 (-0400)
Subject: LP#1584807: Clicking column header should not unsort list
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=59503ede86bb06c97319f12e96bc30604264307d;p=evergreen%2Ftadl.git

LP#1584807: Clicking column header should not unsort list

Clicking column headers in My Account cycled through ascending order,
descending order, and then unsorted. But unsorting a list after clicking a
header is unintutive to the user. Instead, it should toggle between ascending /
descending order.

Test plan
* Using the concerto dataset, log in as user 99999395984 / maes1234
* Go to the Items Out area of my account and click the title column header to
sort the list.
* The list will first sort alphabetically in ascending order, on a second click
will sort alphabetically in descending order, and, on a third click, will
return to the default sort order.
* After loading the patch, clicking the column header should only result in
sorting in ascending and descending order.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
---

diff --git a/Open-ILS/src/templates/opac/parts/myopac/column_sort_support.tt2 b/Open-ILS/src/templates/opac/parts/myopac/column_sort_support.tt2
index eb2bc497d0..6d5ba47ce7 100644
--- a/Open-ILS/src/templates/opac/parts/myopac/column_sort_support.tt2
+++ b/Open-ILS/src/templates/opac/parts/myopac/column_sort_support.tt2
@@ -7,8 +7,6 @@
                 CASE "asc";
                    mkurl('',{sort=>field, sort_type=>'desc'},1);
                 CASE "desc";
-                   mkurl('',{},1);
-                CASE;
                    mkurl('',{sort=>field, sort_type=>'asc'}, 1);
                 END;
 	ELSE;