From: Chris Cormack <chrisc@catalyst.net.nz>
Date: Tue, 8 Apr 2014 21:36:02 +0000 (+1200)
Subject: Fixing the error handling to be consistent
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=5e07e9ee7f4e70df62c598547070adb4d80ce66f;p=working%2FNCIPServer.git

Fixing the error handling to be consistent
---

diff --git a/lib/NCIP/Handler/RequestItem.pm b/lib/NCIP/Handler/RequestItem.pm
index 4fe5f3f..c12464f 100644
--- a/lib/NCIP/Handler/RequestItem.pm
+++ b/lib/NCIP/Handler/RequestItem.pm
@@ -33,15 +33,15 @@ sub handle {
         my $itemid =
           $xpc->findnodes( 'ns:RequestItem/UniqueItemId/ItemIdentifierValue',
             $root );
-        my $biblionumber = $xpc->findnodes( 'ns://BibliographicRecordIdentifier',
+        my $biblionumber = $xpc->findnodes( '//ns:BibliographicRecordIdentifier',
                       $root );
         # request the item
-        my ( $error, $messages ) = $self->ils->request( $userid, $itemid, $biblionumber );
+        my $result = $self->ils->request( $userid, $itemid, $biblionumber );
         my $vars;
         my $output;
-        my $vars->{'barcode'} = $itemid;
+        $vars->{'barcode'} = $itemid;
         $vars->{'messagetype'} = 'RequestItemResponse';
-        if ($error) {
+        if (! $result->{'success'}) {
             $vars->{'processingerror'}        = 1;
             $vars->{'processingerrortype'}    = $messages;
             $vars->{'processingerrorelement'} = 'UniqueItemIdentifier';