From: Cesar Velez <cesar.velez@equinoxinitiative.org>
Date: Wed, 17 Oct 2018 22:06:01 +0000 (-0400)
Subject: LP#1684202 - fix bug the prevented automatic refresh
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=5fa845fb7162df15e7296b649b061f6c038841aa;p=working%2FEvergreen.git

LP#1684202 - fix bug the prevented automatic refresh

Turns out that Array.includes() does not do implicit type convertions
Typical javascript...

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
---

diff --git a/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js b/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
index 58f6e88fe6..3b9f732d5c 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
@@ -1092,7 +1092,7 @@ function($scope , $routeParams , $location , $window , $q , egCore , egHolds , e
                     if (e.data
                         && e.data.records
                         && e.data.records.length
-                        && e.data.records.includes($scope.record_id)
+                        && e.data.records.includes(Number($scope.record_id))
                     ){ // it's for us, refresh grid!
                         console.log("Got broadcast from channel eg.holdings.update for records " + e.data.records);
                         $scope.holdings_record_id_changed($scope.record_id);