From: Mike Rylander <miker@esilibrary.com>
Date: Thu, 25 Sep 2014 16:58:45 +0000 (-0400)
Subject: LP#1198465 Allow fine generator to respect a stop_fines filter
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=64ba9da9dcac570b8ef9f52022bb7b2e43a920c3;p=working%2FEvergreen.git

LP#1198465 Allow fine generator to respect a stop_fines filter

In order to support situations where billings should be generated on
specific circs, even when stop_fines is set, we allow a filter to
be passed.  The default of not passing a filter is the same as requiring
that stop_fines be NULL, which is the pre-commit behavior.

We also remove a never-used parameter.

Signed-off-by: Mike Rylander <miker@esilibrary.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index 0452676b6a..2059a1704e 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -1042,14 +1042,14 @@ sub generate_fines {
     my $self = shift;
     my $client = shift;
     my $circ = shift;
-    my $overbill = shift;
+    my $stop_fines_reasons = shift;
 
     local $OpenILS::Application::Storage::WRITE = 1;
 
     my @circs;
     if ($circ) {
         push @circs,
-            action::circulation->search_where( { id => $circ, stop_fines => undef } ),
+            action::circulation->search_where( { id => $circ, stop_fines => $stop_fines_reasons } ),
             booking::reservation->search_where( { id => $circ, return_time => undef, cancel_time => undef } );
     } else {
         push @circs, overdue_circs();