From: Jeff Davis <jdavis@sitka.bclibraries.ca>
Date: Wed, 8 Jan 2014 21:21:13 +0000 (-0800)
Subject: Fix bug that caused deleted holdings to be visible in SRU/Z39.50 results
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=693e05226dedd282d5d2ae4a5dd91a3877c7d618;p=working%2FEvergreen.git

Fix bug that caused deleted holdings to be visible in SRU/Z39.50 results

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
index 64687720ea..4d4ed93787 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
@@ -2042,7 +2042,7 @@ sub basic_record_holdings {
     $logger->debug("Searching for holdings at orgs [".join(',',@ou_ids)."], based on $ou");
 
     for my $cn (@{$tree->call_numbers}) {
-        next unless ( $cn->deleted eq 'f' || $cn->deleted == 0 );
+        next unless ( $cn->deleted eq 'f' || !$cn->deleted );
 
         my $found = 0;
         for my $c (@{$cn->copies}) {
@@ -2078,7 +2078,7 @@ sub _cp_is_visible {
     my $cp = shift;
 
     my $visible = 0;
-    if ( ($cp->deleted eq 'f' || $cp->deleted == 0) &&
+    if ( ($cp->deleted eq 'f' || !$cp->deleted) &&
          $cp->location->opac_visible eq 't' && 
          $cp->status->opac_visible eq 't' &&
          $cp->opac_visible eq 't' &&