From: Dan Wells <dbw2@calvin.edu>
Date: Thu, 26 May 2011 14:53:42 +0000 (-0400)
Subject: Checking for 'twisty' leads to false negatives in Serial Control
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=6a04ad689bd94f0cddf8ab86f250823d7181f9d5;p=evergreen%2Ftadl.git

Checking for 'twisty' leads to false negatives in Serial Control

Since a tree can be opened with a double-click, we can't rely on 'twisty'
being set to load the child data.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
---

diff --git a/Open-ILS/xul/staff_client/server/serial/manage_dists.js b/Open-ILS/xul/staff_client/server/serial/manage_dists.js
index c1a5df0bc7..9e02c1fec7 100644
--- a/Open-ILS/xul/staff_client/server/serial/manage_dists.js
+++ b/Open-ILS/xul/staff_client/server/serial/manage_dists.js
@@ -647,12 +647,10 @@ serial.manage_dists.prototype = {
             if (!sel_lists[row_type]) sel_lists[row_type] = [];
             sel_lists[row_type].push(id);
 
-            if (twisty) {
-                switch(row_type) {
-                    case 'aou' : obj.on_click_aou(id,twisty); break;
-                    case 'sdist' : obj.on_select_sdist(id,twisty); break;
-                    default: break;
-                }
+            switch(row_type) {
+                case 'aou' : obj.on_click_aou(id,twisty); break;
+                case 'sdist' : obj.on_select_sdist(id,twisty); break;
+                default: break;
             }
         }
 
diff --git a/Open-ILS/xul/staff_client/server/serial/manage_subs.js b/Open-ILS/xul/staff_client/server/serial/manage_subs.js
index 2ce4184457..628ebbe50d 100644
--- a/Open-ILS/xul/staff_client/server/serial/manage_subs.js
+++ b/Open-ILS/xul/staff_client/server/serial/manage_subs.js
@@ -1117,12 +1117,10 @@ serial.manage_subs.prototype = {
             if (!sel_lists[row_type]) sel_lists[row_type] = [];
             sel_lists[row_type].push(id);
 
-            if (twisty) {
-                switch(row_type) {
-                    case 'aou' : obj.on_click_aou(id,twisty); break;
-                    case 'ssub' : obj.on_select_ssub(id,twisty); break;
-                    default: break;
-                }
+            switch(row_type) {
+                case 'aou' : obj.on_click_aou(id,twisty); break;
+                case 'ssub' : obj.on_select_ssub(id,twisty); break;
+                default: break;
             }
         }