From: Bill Erickson <berick@esilibrary.com>
Date: Wed, 19 Feb 2014 15:22:37 +0000 (-0500)
Subject: LP#1262722 Fix DB supersedes/deprecates pgtap test
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=6c16a446894d47776ec336115c096b165ffe4b6a;p=evergreen%2Fpines.git

LP#1262722 Fix DB supersedes/deprecates pgtap test

Sort multi-value arrays before passing them off to pgtap for test
comparison. Otherwise, pgtap tests may fail with:

Failed test 5
        have: {AAAC,AAAB}
        want: {AAAB,AAAC}

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jeff Godin <jgodin@tadl.org>
---

diff --git a/Open-ILS/src/sql/Pg/t/db_patch_dep_checks.pg b/Open-ILS/src/sql/Pg/t/db_patch_dep_checks.pg
index 57c5085cef..19ce243f42 100644
--- a/Open-ILS/src/sql/Pg/t/db_patch_dep_checks.pg
+++ b/Open-ILS/src/sql/Pg/t/db_patch_dep_checks.pg
@@ -29,7 +29,14 @@ SELECT is(
 
 -- AAAF deprecates AAAB, AAAC
 SELECT is(
-    (SELECT ARRAY_AGG(patch) FROM evergreen.upgrade_list_applied_deprecates('AAAF')),
+    (   SELECT ARRAY_AGG(patch)
+        FROM (
+            -- sort the patches to match the expected output
+            SELECT patch
+            FROM evergreen.upgrade_list_applied_deprecates('AAAF')
+            ORDER BY patch
+        ) AS patch
+    ),
     '{AAAB,AAAC}'
 );