From: Michele Morgan <mmorgan@noblenet.org>
Date: Thu, 12 Sep 2019 20:30:47 +0000 (-0400)
Subject: LP#1842431 Make renewal failure reason more appropriate for patron
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=6c99f81251fc4ff8dc31db9dabe621d1276825b4;p=working%2FEvergreen.git

LP#1842431 Make renewal failure reason more appropriate for patron
notifications

Changes the failure reason for the autorenewal to include only the desc,
Removes the textcode of the event, which shouldn't be included in a patron notice.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/Circ/AutoRenew.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/Circ/AutoRenew.pm
index f06adc85e1..e09a8639a8 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/Circ/AutoRenew.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/Circ/AutoRenew.pm
@@ -70,7 +70,7 @@ sub handler {
         my %user_data = (
             copy => $_->target_copy(),
             is_renewed => $is_renewed,
-            reason => !$is_renewed ? sprintf("%s : %s", $evt->{textcode}, substr($evt->{desc}, 0, 140)) : '',
+            reason => !$is_renewed ? $evt->{desc} : '',
             new_due_date => $is_renewed ? $evt->{payload}->{circ}->due_date : '',
             old_due_date => !$is_renewed ? $_->due_date() : '',
         );