From: Bill Erickson <berickxx@gmail.com>
Date: Thu, 17 Dec 2015 21:21:03 +0000 (-0500)
Subject: JBAS-1037 set expire time to 6am to reduce DST issues
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=6ce83643b4b2fd71583949b4329bc9ed6e2bb091;p=working%2FEvergreen.git

JBAS-1037 set expire time to 6am to reduce DST issues

Set patron expire time to 6am so that expire dates spanning DST
boundaries don't make it appear as though the date is off by one day for
clients that don't honor timezone data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/KCLS/utility-scripts/import_students/generate-patrons-from-csv.pl b/KCLS/utility-scripts/import_students/generate-patrons-from-csv.pl
index eb1eff643b..abe13b73ed 100755
--- a/KCLS/utility-scripts/import_students/generate-patrons-from-csv.pl
+++ b/KCLS/utility-scripts/import_students/generate-patrons-from-csv.pl
@@ -304,8 +304,11 @@ sub set_expire_date {
     # if dob occurs after july 1, expire date will occur the following year.
     $expire_year++ if ($mon > 7) or ($mon == 7 and $day > 1);
 
+    # Set hour to 6 to reduce likelyhood of DST/timezone 
+    # confusion causing day-off-by-one issues with external clients.
     my $expire_date = DateTime->new(
-        year => $expire_year, month => 7, day => 1, time_zone => 'local');
+        year => $expire_year, month => 7, 
+        day => 1, hour => 6, time_zone => 'local');
 
     $phash->{expire_date} = $expire_date;
 }