From: erickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Fri, 11 Dec 2009 15:40:17 +0000 (+0000)
Subject: return null as the setting value when a user setting is not applied, instead of retur... 
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=6dd17df0074b94d4c29d3849fa5f5ea1c8fb75af;p=evergreen%2Ftadl.git

return null as the setting value when a user setting is not applied, instead of returning an empty string

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15141 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm b/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
index d1059c7cb8..07ac6ddc01 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
@@ -190,7 +190,7 @@ sub user_settings {
     sub get_setting {
         my($e, $user_id, $setting) = @_;
         my $val = $e->search_actor_user_setting({usr => $user_id, name => $setting})->[0];
-        return '' unless $val; # XXX this should really return undef, but needs testing
+        return undef unless $val; # XXX this should really return undef, but needs testing
         return OpenSRF::Utils::JSON->JSON2perl($val->value);
     }