From: kenstir <kenstir@gmail.com>
Date: Wed, 4 Nov 2020 00:44:45 +0000 (+0000)
Subject: DO NOT MERGE: hacking Circulate to diagnose how to add selfcheck
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=6e0fa666e8ca7198987ffeb5e33b6a99c8f971f3;p=working%2FEvergreen.git

DO NOT MERGE: hacking Circulate to diagnose how to add selfcheck
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index d99d5259c4..148c9a35e4 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -9,6 +9,7 @@ use OpenSRF::Utils::Config;
 use OpenILS::Const qw/:const/;
 use OpenILS::Application::AppUtils;
 use DateTime;
+use Data::Dumper;
 my $U = "OpenILS::Application::AppUtils";
 
 my %scripts;
@@ -267,6 +268,7 @@ sub run_method {
         # overrides have been performed.  Go ahead and re-override.
         $circulator->skip_permit_key(1);
         $circulator->override(1) if ( $circulator->request_precat && $circulator->editor->allowed('CREATE_PRECAT') );
+        $logger->info("kcxxx:checkout.full: override=".$circulator->override);
         $circulator->do_permit();
         $circulator->is_checkout(1);
         unless( $circulator->bail_out ) {
@@ -1603,13 +1605,17 @@ sub do_checkout {
     $self->log_me("do_checkout()");
 
     # make sure perms are good if this isn't a renewal
-    unless( $self->is_renewal ) {
-        return $self->bail_on_events($self->editor->event)
-            unless( $self->editor->allowed('COPY_CHECKOUT') );
-    }
+    # kcxxx: better logic here to allow self-checkout
+    $logger->info("kcxxx:do_checkout: is_renewal=".$self->is_renewal);
+    #unless( $self->is_renewal ) {
+    #    return $self->bail_on_events($self->editor->event)
+    #        unless( $self->editor->allowed('COPY_CHECKOUT') );
+    #}
 
     # verify the permit key
+    $logger->info("kcxxx:do_checkout: check_permit_key=".$self->check_permit_key);
     unless( $self->check_permit_key ) {
+        $logger->info("kcxxx:do_checkout: permit_override=".Dumper($self->permit_override));
         if( $self->permit_override ) {
             return $self->bail_on_events($self->editor->event)
                 unless $self->editor->allowed('CIRC_PERMIT_OVERRIDE');