From: Bill Erickson <berickxx@gmail.com>
Date: Thu, 19 Jan 2017 17:21:11 +0000 (-0500)
Subject: LP#1596595 Hold copy permit test thinko repair
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=6e3dc325a59133f8aec13c06c3fa86a76e7d7010;p=evergreen%2Fpines.git

LP#1596595 Hold copy permit test thinko repair

Pickup and requesting org unit IDs were passed in the wrong order to
the copy permit test.  This resulted in some items, particularly age
protected copies, appearing on the holds pull list even though they were
not (yet) permitted for hold capture at a remoted library.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm b/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
index 5555c86b81..125b395ac7 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
@@ -1043,8 +1043,8 @@ sub copy_is_permitted {
     my $resp = $self->editor->json_query({
         from => [
             'action.hold_retarget_permit_test',
-            $self->hold->request_lib,
             $self->hold->pickup_lib,
+            $self->hold->request_lib,
             $copy->{id},
             $self->hold->usr,
             $self->hold->requestor