From: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Date: Thu, 14 Nov 2013 20:59:55 +0000 (-0500)
Subject: Serials: Batch Receive interface Copy Location widget was inert
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=7036fcc024430cca1f3e2ae8e432fa8835800124;p=evergreen%2Fmasslnc.git

Serials: Batch Receive interface Copy Location widget was inert

Choosing a value from the Copy Location widget wasn't working.  You'd
get a default copy location (or the one supplied by the Receive Unit
Copy Template) no matter what you set that control too.

This is fixed.  One does not read from XUL menulist element by using its
'value' property.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
---

diff --git a/Open-ILS/xul/staff_client/server/serial/batch_receive.js b/Open-ILS/xul/staff_client/server/serial/batch_receive.js
index 92d67d538b..f2a15f7691 100644
--- a/Open-ILS/xul/staff_client/server/serial/batch_receive.js
+++ b/Open-ILS/xul/staff_client/server/serial/batch_receive.js
@@ -428,7 +428,8 @@ function BatchReceiver() {
         var node = dojo.query("*", node_by_name(field, row))[0];
 
         if (typeof(value) == "undefined") {
-            return node.value;
+            return node.selectedItem ?
+                node.selectedItem.value : node.value;
         } else {
             /* XXX The new two lines /should/ each do the same thing, but
              * apparently they don't.  With only one or the other, I get