From: erickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Mon, 4 May 2009 19:51:34 +0000 (+0000)
Subject: simplify the basic po retrieval perm test
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=718cbab2bcadb0ee7a752c1e3ac226ccca54e09e;p=Evergreen.git

simplify the basic po retrieval perm test

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13057 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Acq/Financials.pm b/Open-ILS/src/perlmods/OpenILS/Application/Acq/Financials.pm
index fd56710d12..2ac090f315 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Acq/Financials.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Acq/Financials.pm
@@ -901,12 +901,7 @@ sub retrieve_purchase_order {
 sub po_perm_failure {
     my($e, $po_id, $fund_id) = @_;
     my $po = $e->retrieve_acq_purchase_order($po_id) or return $e->event;
-    my $provider = $e->retrieve_acq_provider($po->provider) or return $e->event;
-    return $e->event unless $e->allowed('MANAGE_PROVIDER', $provider->owner, $provider);
-    if($fund_id) {
-        my $fund = $e->retrieve_acq_fund($po->$fund_id);
-        return $e->event unless $e->allowed('MANAGE_FUND', $fund->org, $fund);
-    }
+    return $e->event unless $e->allowed('VIEW_PURCHASE_ORDER', $po->ordering_agency, $po);
     return undef;
 }