From: Ben Shum <bshum@biblio.org>
Date: Tue, 7 Aug 2012 17:48:31 +0000 (-0400)
Subject: TPAC - fix pickup locations for edit holds
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=71cf2ffe29c15bbc142554eac787cc64bae37cfa;p=evergreen%2Fmasslnc.git

TPAC - fix pickup locations for edit holds

When a patron goes to edit a hold in TPAC, they have the option to
choose a different pickup location. Unfortunately, it looks like that
dropdown does not prevent them from selecting locations that aren't
normally allowed for pickups, such as system groups or consortium
itself.

This patch adds a check for 'can_have_vols_only' to the edit holds
screen.

Credit to Melissa Lefebvre for finally nailing down the source of
the issue.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
---

diff --git a/Open-ILS/src/templates/opac/myopac/holds/edit.tt2 b/Open-ILS/src/templates/opac/myopac/holds/edit.tt2
index d18e063284..175d3195b0 100644
--- a/Open-ILS/src/templates/opac/myopac/holds/edit.tt2
+++ b/Open-ILS/src/templates/opac/myopac/holds/edit.tt2
@@ -48,7 +48,7 @@
                         </th>
                         <td>
                             [% INCLUDE build_org_selector
-                                name='pickup_lib' value=ahr.pickup_lib %]
+                                name='pickup_lib' value=ahr.pickup_lib can_have_vols_only=1 %]
                         </td>
                     </tr>
                     [% IF hold.hold.status < 3 OR hold.hold.status == 7 %]