From: Jason Boyer <JBoyer@equinoxinitiative.org>
Date: Tue, 15 Sep 2020 18:00:54 +0000 (-0400)
Subject: LP1895660: HoldTarger.pm
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=741018e29057729652ca2ed4cb6eea9beea9e709;p=working%2FEvergreen.git

LP1895660: HoldTarger.pm

"order_by" object in a query is not a JSON_HASH or JSON_ARRAY;no ORDER BY generated

json_query and CStoreEditor search_* functions don't want a string field name,
they work with hashes or arrays thereof.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm b/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
index 3816822724..56e9c841a8 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
@@ -1230,7 +1230,7 @@ sub process_recalls {
             checkin_time => undef,
             duration => {'>' => $threshold}
         }, {
-            order_by => 'due_date',
+            order_by => [{ class => 'circ', field => 'due_date'}],
             limit => 1
         }
     ])->[0];