From: Bill Erickson <berick@esilibrary.com>
Date: Wed, 26 Jan 2011 13:39:22 +0000 (-0500)
Subject: for listing holds, taking advantage of batch retrieve args to reduce data size; added... 
X-Git-Tag: opac-tt-poc-demo2~93
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=776a03e0bd48eaa72b308793e44f87b9273eaf4b;p=evergreen%2Fequinox.git

for listing holds, taking advantage of batch retrieve args to reduce data size; added limit/offset to holds list for paging
---

diff --git a/Open-ILS/src/perlmods/OpenILS/WWW/EGCatLoader.pm b/Open-ILS/src/perlmods/OpenILS/WWW/EGCatLoader.pm
index 676781f266..213f4cb618 100644
--- a/Open-ILS/src/perlmods/OpenILS/WWW/EGCatLoader.pm
+++ b/Open-ILS/src/perlmods/OpenILS/WWW/EGCatLoader.pm
@@ -408,6 +408,9 @@ sub load_myopac_holds {
     my $e = $self->editor;
     my $ctx = $self->ctx;
 
+    my $limit = $self->cgi->param('limit') || 10;
+    my $offset = $self->cgi->param('offset') || 0;
+
     my $circ = OpenSRF::AppSession->create('open-ils.circ');
     my $hold_ids = $circ->request(
         'open-ils.circ.holds.id_list.retrieve', 
@@ -415,20 +418,30 @@ sub load_myopac_holds {
         $e->requestor->id
     )->gather(1);
 
+    $hold_ids = [ @$hold_ids[$offset..($offset + $limit - 1)] ];
+
     my $req = $circ->request(
         'open-ils.circ.hold.details.batch.retrieve', 
         $e->authtoken, 
-        $hold_ids
+        $hold_ids,
+        {
+            suppress_notices => 1,
+            suppress_transits => 1,
+            suppress_mvr => 1,
+            suppress_patron_details => 1,
+            include_bre => 1
+        }
     );
 
     # any requests we can fire off here?
-    # XXX use marc attrs instead of the mvr's returned by hold.details
     
     $ctx->{holds} = []; 
     while(my $resp = $req->recv) {
         my $hold = $resp->content;
-        # need to fetch anything else?
-        push(@{$ctx->{holds}}, $hold);
+        push(@{$ctx->{holds}}, {
+            hold => $hold,
+            marc_xml => XML::LibXML->new->parse_string($hold->{bre}->marc)
+        });
     }
 
     $circ->kill_me;