From: Jeff Godin <jgodin@tadl.org>
Date: Tue, 2 Oct 2018 12:32:54 +0000 (-0400)
Subject: LP#1796942 Treat VISA SIP payments as credit card
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=7b3a620b121b33cd88308345e2866b491cba9860;p=evergreen%2Ftadl.git

LP#1796942 Treat VISA SIP payments as credit card

Treat sip_payment_type 01 (VISA) as a credit_card_payment.

Previously, we only handled payment type 02 (credit card) and 01
fell through to be treated as a cash_payment.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm
index b9c0654553..df424dda3f 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm
@@ -189,7 +189,8 @@ sub do_fee_payment {
 sub pay_bills {
     my ($self, $paymentref) = @_;
     my $user = $self->patron->{user};
-    if ($self->sip_payment_type eq '02') {
+    if ($self->sip_payment_type eq '02' || $self->sip_payment_type eq '01') {
+        # '01' is "VISA"
         # '02' is "credit card"
         my $transaction_id = $self->transaction_id ? $self->transaction_id : 'Not provided by SIP client';
         return $U->simplereq('open-ils.circ', 'open-ils.circ.money.payment', $self->{authtoken},